Jean-Daniel Cryans has posted comments on this change.

Change subject: java: prohibit use of a KuduTable from an unassociated 
KuduClient
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7362/2/java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RequestTracker.java:

Line 72:     // TODO(todd): this is weird, why are we calling completed on a -1 
seqno.
Have you seen -1 seqno being passed here?


http://gerrit.cloudera.org:8080/#/c/7362/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
File 
java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java:

Line 50:     for (int i = 2; i <= 4; i++) {
You asked me offline why I added an idempotency test and TBH I really don't 
remember why. You were in this code recently so you probably have more context 
than I do at this point, so unless David says this is wrong then it's likely 
right.


-- 
To view, visit http://gerrit.cloudera.org:8080/7362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4a977f36b9c7ba3758322a2216ce90208b5d014
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to