Grant Henke has posted comments on this change. Change subject: KUDU-2066. Add experimental Gradle build support ......................................................................
Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradle/wrapper.gradle File java/gradle/wrapper.gradle: Line 1: // Ensure the wrapper script is generated based on the version defined in the project > License header? Done http://gerrit.cloudera.org:8080/#/c/7258/10/java/gradlew File java/gradlew: Line 1: #!/usr/bin/env sh > Does this need a copyright/license header? It's a good question. It's auto-generated by gradle except for a small snippet of code that is injected. That small snippet of code comes from wrapper.gradle which does have a license header. So I think this falls under the "generated" code exception. Line 69: curl -o gradle/wrapper/gradle-wrapper.jar https://raw.githubusercontent.com/gradle/gradle/master/gradle/wrapper/gradle-wrapper.jar > This should probably point to a specific tag instead of master. Done -- To view, visit http://gerrit.cloudera.org:8080/7258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib257cdd019a1f383c886b9238bb47d96576c4421 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
