Dan Burkert has posted comments on this change. Change subject: Integrate Mustache templates to webserver ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/7448/13/src/kudu/util/easy_json.h File src/kudu/util/easy_json.h: Line 191: std::ostream& operator<<(std::ostream& os, const EasyJson& ej); We talked about this offline - but I'd skip this API for now. There's a note in the RapidJson about the overhead of OStreamWrapper, so it's not a clear perf. win. -- To view, visit http://gerrit.cloudera.org:8080/7448 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cf8181b2b2904a57c9b24ce73316b92a4f6700f Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sam Okrent <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sam Okrent <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
