Andrew Wong has posted comments on this change. Change subject: disk failure: error-handling macros in blocks ......................................................................
Patch Set 18: (7 comments) http://gerrit.cloudera.org:8080/#/c/7030/17/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: PS17, Line 534: RETURN_NOT_OK_HANDLE_DISK_FAILURE(env_->SyncDir(s), : error_manager_->RunErrorNotificationCb(location.data_dir())); : } > Combine? Ah thanks, this was a bit different in an intermediate-version. Done http://gerrit.cloudera.org:8080/#/c/7030/14/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1095: LogBlockContainer* container_; > Right but I don't see any RETURN_NOT_OK_HANDLE_ERROR calls in LogWritableBl Got it, done. Line 1745: return; > I see. I think the failure handling policy for a tablet is out of scope for Done http://gerrit.cloudera.org:8080/#/c/7030/17/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1304: // A reference to this block's metadata. > Also unnecessar Ahh, right, because IO is put off to the containers. Didn't catch that earlier. Line 2336: > What about this one? Done Line 2345: // Disk failures do not suffer from this issue because, on the next startup, > And the calls in here? Done http://gerrit.cloudera.org:8080/#/c/7030/17/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: > There are still some changes to this file that don't belong in this patch. Done -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
