Andrew Wong has posted comments on this change. Change subject: KUDU-2085. Fix crash when seeking past end of prefix-encoded blocks ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Comment nit, otherwise lgtm http://gerrit.cloudera.org:8080/#/c/7545/1/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: PS1, Line 237: static string RandomFormatString(Random* r) { : char buf[8]; nit: a comment here explaining what a "random" format string is would be nice (e.g. could refer to random length too, but that's not the case) -- To view, visit http://gerrit.cloudera.org:8080/7545 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1670b2244d586e4920f0603c48f65ed993a3b12b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
