Adar Dembo has posted comments on this change. Change subject: KUDU-2039 Fix the table count in the /tables page of master webUI ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7568/1/src/kudu/master/master-path-handlers.cc File src/kudu/master/master-path-handlers.cc: Line 139: Nit: leading whitespace here, please trim. Line 143: TableMetadataLock l(table.get(), TableMetadataLock::READ); We're already looping over the tables and locking them on L152-164. Could you reuse that loop to compute the table count? Line 150: Nit: leading whitespace here, please trim. -- To view, visit http://gerrit.cloudera.org:8080/7568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03c2fa1e3f26a9927d4b748a49dd5cee22d8f9d5 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Abhishek Talluri <abhishektall...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
