Dan Burkert has posted comments on this change.

Change subject: Add Maintenance Manager visualizer
......................................................................


Patch Set 7:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7570/7/www/maintenance-manager.mustache
File www/maintenance-manager.mustache:

Line 173:     } else if (millis < 1000 * 60) {
> I think a better threshold here might be 300 or something... otherwise anyw
My personal preference is to always make it the largest possible unit, but keep 
around 3 significant digits of precision.


PS7, Line 180:   // Translates a thread id hex string into a counting-number 
identifier.
             :   function threadString(thread_id) {
             :     return "Thread " + (threads.indexOf(thread_id) + 1);
             :   }
> would rather figure a way to show pids here so you can correlate with trace
https://gerrit.cloudera.org/#/c/7621/ switches the MM to use the system TID


-- 
To view, visit http://gerrit.cloudera.org:8080/7570
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If2e7f18ac4834791a94d935b540930b11ea14532
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <samuel.okr...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <samuel.okr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to