Grant Henke has posted comments on this change. Change subject: Give more context on errors reading cfiles ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7620/1/src/kudu/cfile/cfile-test.cc File src/kudu/cfile/cfile-test.cc: Line 852: ASSERT_STR_MATCHES(s.ToString(), "block [0-9]+"); This test doesn't necessarily validate every error message. We corrupt each bit, but not necessarily to trigger ever "kind" of failure. I don't think a test like that is reasonable or worth it. But I thought I would mention it. http://gerrit.cloudera.org:8080/#/c/7620/1/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: Line 196: return Status::Corruption("invalid CFile header size", std::to_string(header_size)); Should the block_id be given here too? (and other similar size/parse checks) -- To view, visit http://gerrit.cloudera.org:8080/7620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bda5688a020032c512235ee574cb3e53c7872af Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
