Jean-Daniel Cryans has posted comments on this change.

Change subject: kudu client tools for hadoop and spark 
import/export(csv,parquet,avro)
......................................................................


Patch Set 7:

(6 comments)

Took a closer look at the scala files, we're almost there :)

http://gerrit.cloudera.org:8080/#/c/7421/7/java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala
File 
java/kudu-spark-tools/src/main/scala/org/apache/kudu/spark/tools/ImportExportFiles.scala:

PS7, Line 41: kudu
nit: Kudu


PS7, Line 41: form
nit: from


PS7, Line 42: currently we support
replace with "the following formats are supported"


PS7, Line 107: doesn't not
huh? :)


PS7, Line 154: Csv
nit: CSV


Line 157:     LOG.info(s"Spark version detected as" + sc.version)
I'm not really familiar with Spark, is this really useful?


-- 
To view, visit http://gerrit.cloudera.org:8080/7421
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If462af948651f3869b444e82151c3559fde19142
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sandish Kumar HN <sanysand...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sandish Kumar HN <sanysand...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to