Alexey Serbin has posted comments on this change.

Change subject: remove 'using std::...' and other from header files
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/clock/hybrid_clock.cc
File src/kudu/clock/hybrid_clock.cc:

Line 371: std::string HybridClock::Stringify(Timestamp timestamp) {
> this change and below shouldn't be necessary I think?
I think you are right.  It was some sort of mishap during fast updates.  Thank 
you for pointing at this.


http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/consensus/log-test-base.h
File src/kudu/consensus/log-test-base.h:

Line 53: using std::string;
> shouldn't these be removed?
uh-oh, my bad -- it seems I put using into the wrong place.

Will remove this.


http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/util/debug-util.cc
File src/kudu/util/debug-util.cc:

Line 262:   std::string ret;
> lots of changes in this file, maybe add using statements instead?
Indeed, using std::string would be better here.


http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/util/memcmpable_varint-test.cc
File src/kudu/util/memcmpable_varint-test.cc:

Line 96:     std::pair<uint64_t, uint64_t> p1 =
> another one with a lot of changes, consider using
Done


http://gerrit.cloudera.org:8080/#/c/7628/1/src/kudu/util/random-test.cc
File src/kudu/util/random-test.cc:

Line 105:   std::vector<int> population;
> add using std::vector
Done.  I also added using for std::unordered_set and std::numeric_limits.


-- 
To view, visit http://gerrit.cloudera.org:8080/7628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea777af2d881abdb593f9e6f667e613cca8b2fd3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to