Hao Hao has posted comments on this change. Change subject: KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/7207/14/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: Line 396: Status FileWritableBlock::FlushAndFinalize(FlushMode mode) { > Hmm I'm not sure this is doing what we want when block_manager_flush_on_fin Good catch, thanks! Do you think it is better to remove 'FLAGS_block_manager_flush_on_finalize'? And always flush on finalize? Feel it is hard to have a clean way to accommodate both flags behavior. As its functionality somewhat overlapped with 'FLAGS_block_coalesce_close'. -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
