Andrew Wong has posted comments on this change. Change subject: disk failure: add persistent disk states ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/7270/10/src/kudu/fs/block_manager_util.cc File src/kudu/fs/block_manager_util.cc: Line 26: #include "kudu/fs/fs_manager.h" > warning: #includes are not sorted properly [llvm-include-order] Done Line 292: const string uuid = pb_at_i.uuid(); > warning: the const qualified variable 'uuid' is copy-constructed from a con Done http://gerrit.cloudera.org:8080/#/c/7270/10/src/kudu/fs/block_manager_util.h File src/kudu/fs/block_manager_util.h: Line 107: static Status CheckIntegrity(const std::vector<PathInstanceMetadataFile*>& instances, > warning: function 'kudu::fs::PathInstanceMetadataFile::CheckIntegrity' has Done http://gerrit.cloudera.org:8080/#/c/7270/10/src/kudu/fs/data_dirs-test.cc File src/kudu/fs/data_dirs-test.cc: Line 22: #include <gtest/gtest.h> > warning: #includes are not sorted properly [llvm-include-order] Done Line 30: #include "kudu/gutil/strings/substitute.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifddf0817fe1a82044077f5544c400c88de20769f Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
