Alexey Serbin has posted comments on this change.

Change subject: KUDU-1942. Kerberos fails to log in on hostnames with capital 
letters
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/7693/2//COMMIT_MSG
Commit Message:

PS2, Line 12: With this change I was able to set up a working cluster on my 
laptop
            : with a capitalized hostname, where before it would fail as 
described in
            : the JIRA.
Is it worth adding a small test to catch a regression, if any?


http://gerrit.cloudera.org:8080/#/c/7693/2/src/kudu/security/init.cc
File src/kudu/security/init.cc:

PS2, Line 20: #include <ctype.h>
nit: maybe, #include <cctype> ?


-- 
To view, visit http://gerrit.cloudera.org:8080/7693
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef65dd827459476a2d225d8e3f7c80ff2fdf627
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil <[email protected]>
Gerrit-HasComments: Yes

Reply via email to