Will Berkeley has posted comments on this change. Change subject: Add tablet state summary metrics and fix KUDU-2044 ......................................................................
Patch Set 4: (4 comments) > Build Successful > > http://jenkins.kudu.apache.org/job/kudu-gerrit/9367/ : SUCCESS Not sure I believe 2/3 were unrelated. My only suspect is the switch from atomic<bool> to plain bool w/ spinlock for hidden_ member of metrics but the TSAN logs don't indicate that. http://gerrit.cloudera.org:8080/#/c/7618/4/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 104: DEFINE_int32(tablet_state_walk_min_period_ms, 1000, > Maybe higher? 5 or 10s? Done. 5s. Line 107: TAG_FLAG(tablet_state_walk_min_period_ms, advanced); > Probably experimental, I can't imagine someone actually modifying this in r Done http://gerrit.cloudera.org:8080/#/c/7618/4/src/kudu/tserver/ts_tablet_manager.h File src/kudu/tserver/ts_tablet_manager.h: Line 86: // TODO: will also be responsible for keeping the local metadata about > warning: missing username/bug in TODO [google-readability-todo] Done PS4, Line 303: int NumNotStartedTablets(); : : int NumBootstrappingTablets(); : : int NumRunningTablets(); : : int NumFailedTablets(); : : int NumQuiescingTablets(); : : int NumShutdownTablets(); > Nit: maybe don't separate these with empty lines, so it's clear that the co Done -- To view, visit http://gerrit.cloudera.org:8080/7618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c82987ffe4f37e8af95972bde97841e44c521d9 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
