Andrew Wong has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets ......................................................................
Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/7440/7/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: PS7, Line 232: case tserver::TabletServerErrorPB::TABLET_FAILED: // fall-through > the difference seems to be that TABLET_NOT_FOUND forces a new metadata fetc Ah, thanks for pointing that out. It seems like the the staleness needs to be refreshed when there is a config change. In this case, even though we know a config change is impending, it may not have happened yet, but it's a fair point that we may still want to retry. If we assume the time between a failure and the config change (maybe a bit longer than the heartbeat interval) is shorter than the time between the client staleness check and it doing the actual metadata re-fetch, this isn't too big a deal (and still not a big deal otherwise). Went with your suggestion of TABLET_NOT_FOUND. http://gerrit.cloudera.org:8080/#/c/7440/8/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 291: return; > warning: do not use 'else' after 'return' [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/7440/10/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS10, Line 618: ::str > nit remove Done PS10, Line 623: > nit: explain that otherwise this notification is ignored Done http://gerrit.cloudera.org:8080/#/c/7440/10/src/kudu/tablet/tablet_replica.cc File src/kudu/tablet/tablet_replica.cc: PS10, Line 233: turn; > doesn't this have to include FAILED too? Done http://gerrit.cloudera.org:8080/#/c/7440/10/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS10, Line 176: SetupErrorAndRespond(resp->mutable_error(), s, TabletServerErrorPB::TABLET_NOT_RUNNING, > likely slightly cleaner to do: Done http://gerrit.cloudera.org:8080/#/c/7440/10/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS10, Line 659: usMessage("De > more informative status message Done -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f61585b02fbe270d215bf7f49c0d390ceee3345 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
