Dan Burkert has posted comments on this change. Change subject: [iwyu] first pass ......................................................................
Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/common/wire_protocol.h File src/kudu/common/wire_protocol.h: Line 29: class optional; > Yes, for some reason IWYU prefers this to optional_fwd.hpp. Probably, once ok sounds good to me http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/tools/ksck.h File src/kudu/tools/ksck.h: Line 387: std::ostream* out = nullptr); > Ah, yes. It seems I just added it in to keep things simpler. Is it OK to I'm ok with moving the impl, but I was just curious about why you changed the default value (it seemed simpler before). http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/util/slice.cc File src/kudu/util/slice.cc: Line 22: #include "kudu/gutil/port.h" > That's for PREDICT_FALSE, not int types. ah ok thanks. http://gerrit.cloudera.org:8080/#/c/4738/18/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: Line 33: #include <boost/smart_ptr/shared_ptr.hpp> > yep, that's another manifestation of the boost mappings: <boost/smart_ptr/d ahh, I do remember dealing with this some time in the way past around the time we moved to c++ 11. Had totally forgotten that's where yield comes from. -- To view, visit http://gerrit.cloudera.org:8080/4738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923091be36a1c03fac34dd73e6b17e17ac9ceaa Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
