Alexey Serbin has posted comments on this change.

Change subject: [iwyu] update on the internal and boost mappings
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7696/1//COMMIT_MSG
Commit Message:

PS1, Line 11: IWUY
> IWYU
Done


http://gerrit.cloudera.org:8080/#/c/7696/1/build-support/iwyu/mappings/boost-all.imp
File build-support/iwyu/mappings/boost-all.imp:

Line 960:     { include: ["<boost/core/explicit_operator_bool.hpp>", private, 
"<boost/optional/optional.hpp>", public ] },
> Are these also imported from upstream? Or your changes?
Done


http://gerrit.cloudera.org:8080/#/c/7696/1/thirdparty/patches/llvm-iwyu-include-picker.patch
File thirdparty/patches/llvm-iwyu-include-picker.patch:

> You need to bump LLVM's patchlevel for this to be incorporated in existing 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a20616093f362a5b5ae30627b6121313b50efa2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to