Dan Burkert has posted comments on this change. Change subject: add outputmetric collecting for the kudu data writing ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7754/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: Line 222: val method = obj.getClass.getDeclaredMethod(methodName, classArgs: _*) I don't think it's a good idea to be reaching in to the private APIs of Spark and calling methods like this. We have to support a wide range of Spark versions, and they could change this API at any point. Is there any way to update these metrics through a public API? PS1, Line 239: rowSize I think this would be better named 'numRows', since 'rowSize' might be confused as the width of the rows. -- To view, visit http://gerrit.cloudera.org:8080/7754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3ca4389090f25834d165d36b83f77f1cfa3f726 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: caiconghui <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
