Mike Percy has posted comments on this change. Change subject: consensus: Improve contract for API to fetch last-logged op id ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7717/3/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: Line 114: PeerMessageQueue::PeerMessageQueue(scoped_refptr<MetricEntity> metric_entity, > warning: the parameter 'metric_entity' is copied for each invocation but on This has cascading effects and I don't want to fix all the downstream classes in this patch. We'll slowly work toward that in the future. Line 115: scoped_refptr<log::Log> log, > warning: the parameter 'log' is copied for each invocation but only used as same -- To view, visit http://gerrit.cloudera.org:8080/7717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4e4501a61cd40fdee0dc918b77675a0bc2515e7 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
