Alexey Serbin has posted comments on this change. Change subject: Unbreak build after efb5395bdf8b89077b403c8a01528e63b346c49a ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7762/1/src/kudu/rpc/connection_id.cc File src/kudu/rpc/connection_id.cc: PS1, Line 22: #include <ostream> > I thought you decided we had to add ostream everywhere that we used logging Yep, but that's only when there is a construct like LOG(INFO) << "mega info"; in the file. The <ostream> in that case is needed for the ostream& operator<<(ostream&). Otherwise, IWYU will say the <ostream> should be removed. -- To view, visit http://gerrit.cloudera.org:8080/7762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If54a615a491cc3ebf22385d5fdb5817a6c992448 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
