Mike Percy has posted comments on this change. Change subject: consensus: Tablet copy should clear last-logged opid from superblock ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7718/3//COMMIT_MSG Commit Message: Line 9: Keeping around irrelevant information is bad hygiene. > Mike and I discussed offline... it seems like this might not be a great ide The patch as-written only clears the last-logged opid when we transition to TABLET_DATA_READY, which is only synced after tablet copy is successfully completed. So the scenario summarized above wouldn't be affected negatively by this (correctness related) patch. I definitely agree we want to preserve the last-logged opid as much as possible (for availability reasons) and I am planning on ensuring that we do that in a follow-up patch. -- To view, visit http://gerrit.cloudera.org:8080/7718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa84d59c63222e9ddb05dca492f9ecd47b5c63ea Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
