Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7765/1//COMMIT_MSG Commit Message: Line 13: This changelist addresses KUDU-1894. > Curious why you specified this here and didn't just prefix the commit summa That's because KUDU-1894 was about some different issue in the beginning. >From the other side, it's better to stick to current interpretation: KUDU-1894 >contains the exact information about the deadlock this patch fixes. http://gerrit.cloudera.org:8080/#/c/7765/1/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: PS1, Line 485: Netty's > Netty (here and below) Done PS1, Line 491: if > of a Done Line 573: @GuardedBy("lock") > The annotation should be removed, right? Done -- To view, visit http://gerrit.cloudera.org:8080/7765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
