Adar Dembo has posted comments on this change. Change subject: consensus_peers: replace bespoke Raft heartbeat logic with periodic timers ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7734/2//COMMIT_MSG Commit Message: Line 15: heartbeat load, I think it makes sense to do it. > perhaps worth re-running the experiment from https://docs.google.com/docume Sure, I'll do that post-commit. http://gerrit.cloudera.org:8080/#/c/7734/2/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: Line 140: > I think std::function has an implicit constructor from any callable (seriou Thanks, fixed. -- To view, visit http://gerrit.cloudera.org:8080/7734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f7e1761d9f36dc6a25bd8e3e7d7a3b5c402afbf Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
