Adar Dembo has posted comments on this change. Change subject: rpc: periodic timers ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic-test.cc File src/kudu/rpc/periodic-test.cc: Line 88: TEST_P(PeriodicTimerTest, TestReset) { > yea, of course it will be timing-dependent. But perhaps just running the wh OK, I've changed the period from 20ms to 200ms to stave off potential TSAN flakiness. I looped the latest version 1000 times and got no failures. http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic.cc File src/kudu/rpc/periodic.cc: Line 38: DEFINE_double(periodic_period_jitter_pct, 0.25, > See my reply to the other comment about what I would do to make this go awa I did end up renaming the flag (to remove 'period'), but your general point still stands, and in the latest version of this patch the flag is gone. http://gerrit.cloudera.org:8080/#/c/7733/2/src/kudu/rpc/periodic.h File src/kudu/rpc/periodic.h: PS2, Line 59: periodic_period_jitter_pct > ok, I'm alright with a gflag on the argument that they're easier to change Dan's approach is compelling. I've rewritten the code in that way. -- To view, visit http://gerrit.cloudera.org:8080/7733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23f80631a5591b1ac023974f3d7d9eb1576cdb86 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
