Mike Percy has posted comments on this change. Change subject: KUDU-1407: reassign failed tablets ......................................................................
Patch Set 19: (6 comments) http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: PS19, Line 628: peers_map_ This should be protected by queue_lock_ PS19, Line 632: queue_state_.current_term This should be protected by queue_lock_ PS19, Line 633: NotifyObserversOfFailedFollower No need to hold queue_lock_ while calling NotifyObserversOfFailedFollower() because the thread pool it uses is set in the constructor http://gerrit.cloudera.org:8080/#/c/7440/19/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 310: { "--master_tombstone_evicted_tablet_replicas=false" })); nit: add a comment for why we are specifying this flag http://gerrit.cloudera.org:8080/#/c/7440/17/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS17, Line 655: > Failures when writing the data directory are passed off as WARN_NOT_OK() (s ok PS17, Line 658: > Ah, I see. I'll update the comment. ok. -- To view, visit http://gerrit.cloudera.org:8080/7440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f61585b02fbe270d215bf7f49c0d390ceee3345 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
