Hello Mike Percy,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7794

to review the following change.

Change subject: remove control flow warnings
......................................................................

remove control flow warnings

This patch eliminates two -Wreturn-type warnings by adding default switch
statements that crash.

  ../../src/kudu/consensus/consensus_meta.cc: In member function ‘const 
kudu::consensus::RaftConfigPB& 
kudu::consensus::ConsensusMetadata::config_unlocked(kudu::consensus::RaftConfigState)
 const’:
  ../../src/kudu/consensus/consensus_meta.cc:136:1: warning: control reaches 
end of non-void function [-Wreturn-type]
   }

  ../../src/kudu/integration-tests/fuzz-itest.cc: In function ‘TestOpType 
kudu::tablet::PickOpAtRandom(kudu::tablet::TestOpSets)’:
  ../../src/kudu/integration-tests/fuzz-itest.cc:477:1: warning: control 
reaches end of non-void function [-Wreturn-type]
   }

Change-Id: I45ca805bc7db2e234f55d2c59efcf01a28593e12
---
M src/kudu/consensus/consensus_meta.cc
M src/kudu/integration-tests/fuzz-itest.cc
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/7794/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I45ca805bc7db2e234f55d2c59efcf01a28593e12
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Mike Percy <[email protected]>

Reply via email to