Alexey Serbin has posted comments on this change. Change subject: open FS layout in presence of disk failure ......................................................................
Patch Set 3: (5 comments) A quick first pass http://gerrit.cloudera.org:8080/#/c/7784/3//COMMIT_MSG Commit Message: PS3, Line 20: mangers' looks like a typo Is that supposed to be "directory managers'" or "managers'" ? http://gerrit.cloudera.org:8080/#/c/7784/3/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: PS3, Line 180: set<string> all_roots; : all_roots.insert(wal_fs_root_); : for (const string& data_fs_root : data_fs_roots_) { : all_roots.insert(data_fs_root); : } nit: consider set<string> all_roots(data_fs_roots_.begin(), data_fs_roots_.end()); all_roots.insert(wal_fs_root_); PS3, Line 228: if (!ContainsKey(unique_roots, root.first)) { : canonicalized_data_fs_roots_.emplace_back(root); : canonicalized_all_fs_roots_.emplace_back(root); : InsertOrDie(&unique_roots, root.first); : } Consider using InsertIfNotPresent() instead to avoid double look-ups: if (InsertIfNotPresent(&unique_roots, root.first)) { canonicalized_data_fs_roots_.emplace_back(root); canonicalized_all_fs_roots_.emplace_back(root); } PS3, Line 248: string wal_root Is it necessary to make a copy here? Why not to use const reference here instead? PS3, Line 251: string meta_root ditto -- To view, visit http://gerrit.cloudera.org:8080/7784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2a1c824526ed52a6b90ddfbc735cecc4c491118 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
