Alexey Serbin has posted comments on this change. Change subject: [rpc] faster generation of KRPC call ID ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7813/2//COMMIT_MSG Commit Message: PS2, Line 48: const int u_bound = 800000000 + (random() % 100); : int n = 0; : for (int i = 0; i < u_bound; ++i) { : n = next_id(); : } > I think your microbenchmark is invalid. With -O3 it compiles to this assemb Yep, I suspected that it's not a good benchmark, but the newer code looked better IMO. -- To view, visit http://gerrit.cloudera.org:8080/7813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I03726343d222bcd241c2c2a5a1670a672f8e5cb6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
