Adar Dembo has posted comments on this change. Change subject: Add more trace counters and timings ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7819/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 764: virtual Status Read(uint64_t offset, Slice* result) const OVERRIDE { > I think this already gets traced at the LBM level, no? Yeah but you don't like having traces at multiple levels? What if we have heavy non-LBM RWFile usage in the future? -- To view, visit http://gerrit.cloudera.org:8080/7819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie99bc9e06be682e1595745f154b7dded3903bd6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
