Adar Dembo has posted comments on this change. Change subject: rpc: allow setting --rpc_tls_min_protocol on older RHEL versions ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7821/1/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: Line 131: // Hard code the SSL_OP_NO_TLSv1 and SSL_OP_NO_TLSv1_1 flags from OpenSSL Makes sense, but rather than the macros here, can we do something like this earlier, after including the openssl headers: #ifndef SSL_OP_NO_TLSv1 #define SSL_OP_NO_TLSv1 0x04000000U #endif #ifndef SSL_OP_NO_TLSv1_1 #define SSL_OP_NO_TLSv1_1 0x10000000U #endif That should improve readability in the code down here. -- To view, visit http://gerrit.cloudera.org:8080/7821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic61f31788d63072fae609c6a2186e52d5e2467b7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
