Mike Percy has posted comments on this change. Change subject: Fix flaky ts_recovery-itest TestChangeMaxCellSize ......................................................................
Patch Set 1: (1 comment) Yeah, that DCHECK is not useful. http://gerrit.cloudera.org:8080/#/c/7820/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 1014: if (!replica->error().ok()) { This has an ABA problem, potentially. How about: const Status& error = replica->error(); if (!error.ok()) { StatusToPB(reported_tablet->mutable_error(), error_status); } -- To view, visit http://gerrit.cloudera.org:8080/7820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f0a6b19756777e5f4081ef6c8cb5af4ecc8a3d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
