Grant Henke has posted comments on this change. Change subject: [java] Reuse JVM across tests ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7825/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java: Line 70: public void testLowTimeoutScans() throws Exception { I broke these tests out because it looks like sometimes a warm client could actually succeed in 1ms. Its also nice to have a method for each thing tested. http://gerrit.cloudera.org:8080/#/c/7825/1/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/KuduContext.scala: Line 350: def clear(): Unit = { Having cached connection that outlived the client was causing issues when we started a whole new cluster with a new certificates in later tests. Is their any real-world issue having JVM wide cached connections like this could cause? -- To view, visit http://gerrit.cloudera.org:8080/7825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e4c6d53054d5da4f2ecf9f4130a51df13d4fa6c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
