Alexey Serbin has posted comments on this change. Change subject: KUDU-1894 fixed deadlock in client.Connection ......................................................................
Patch Set 5: > This looks good to me, but obviously this code is extremely > fragile. We should figure out a way to make this more robust down > the line. I took a quick look at the server implementation and it > seems like it would be OK with out of order call IDs. Thank you for the review. I think there will be a good opportunity to make the code more robust when switching to new version of Netty (4.x or even 5.0). At least, with Netty 4.x a lot of multi-threading and locking woes should go away because of stronger guarantees on event handling: http://netty.io/wiki/new-and-noteworthy-in-4.0.html#well-defined-thread-model -- To view, visit http://gerrit.cloudera.org:8080/7765 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a0edc3e3accbcff60f2cde641ee470312bbd27a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
