Dan Burkert has posted comments on this change. Change subject: catalog_manager: don't log deleted tables/tablets at startup ......................................................................
Patch Set 1: (3 comments) How confident are we that the Substitutes won't be more eagerly evaluated than the << operations? http://gerrit.cloudera.org:8080/#/c/7826/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 1308: LOG(INFO) << Substitute("Servicing CreateTable request from $0: $1", The previous version has a newline before the table descriptor. I've always found these messages obnoxiously verbose, but I think as long as we're using SecureDebugString and not the Short variant, it's best to keep the leading newline. Line 2357: VLOG(2) << Substitute("Received tablet report from $0: $1", Might be good to put a leading newline on the tablet report here for the same reason. PS1, Line 3133: deleted I think it was correct before -- To view, visit http://gerrit.cloudera.org:8080/7826 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I557ebfe9d3ce1663e7f7c189f0087bdd29a09306 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
