Dan Burkert has posted comments on this change. Change subject: feat: add the wrapper for the Iterator by using InterruptibleIterator ......................................................................
Patch Set 2: That's a good point about killTaskIfInterrupted being private to spark. I think there's a way to get the best of both worlds here: TaskContext.isInterrupted appears to be stable, and we can use it once per row batch from Kudu to check and throw. The only downside is we don't get the 'reason' for the task interruption, but hopefully that will be logged elsewhere. Also, please include a test for task cancellation so we can make sure this doesn't regress. -- To view, visit http://gerrit.cloudera.org:8080/7753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b4284f2c0a40cd7ba8cf2b76e0403592552c814 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: caiconghui <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: caiconghui <[email protected]> Gerrit-HasComments: No
