Mike Percy has posted comments on this change. Change subject: consensus: Save previous last-logged OpId across tablet copies ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7888/1/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: Line 2854: vector<string> master_flags = { > nit: const? Done http://gerrit.cloudera.org:8080/#/c/7888/1/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: PS1, Line 348: RETURN_NOT_OK(DownloadBlocks()); : RETURN_NOT_OK(DownloadWALs()); > Just curious: what if the crash happens between calls of there two methods? We may orphan the blocks, but nothing "bad" happens. Relevant tests are in tablet_copy-itest (see BadTabletCopyITest). -- To view, visit http://gerrit.cloudera.org:8080/7888 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie886764adbdc6d84406df44d6cdb693d038bcd57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
