Dan Burkert has posted comments on this change. Change subject: KUDU-2098. Drop Spark 1 Support ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7690/2//COMMIT_MSG Commit Message: Line 9: Spark 2 has been available for over a year and the value of May want to throw a link to https://lists.apache.org/thread.html/1bcd0e048e7fe8d91f69c468d1577987215484395dd0540b7fa902cf@%3Cdev.kudu.apache.org%3E in here. http://gerrit.cloudera.org:8080/#/c/7690/2/java/README.md File java/README.md: Line 54: $ mvn verify Probably should call out that this requires Java 8, since it's 7 or 8 above. http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/pom.xml File java/kudu-spark-tools/pom.xml: Line 30: <artifactId>kudu-${spark.version.label}-tools_${scala.binary.version}</artifactId> I think we should hard code this now, IntelliJ has a big problem with properties in artifact names. http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala File java/kudu-spark-tools/src/test/scala/org/apache/kudu/spark/tools/ITBigLinkedListTest.scala: Line 41: ss) keep the indent the same. http://gerrit.cloudera.org:8080/#/c/7690/2/java/kudu-spark/pom.xml File java/kudu-spark/pom.xml: Line 23: <artifactId>kudu-${spark.version.label}_${scala.binary.version}</artifactId> Same here. I wouldn't be against getting rid of all of the interpolation of spark and scala versions in artifact IDs, but maybe we'll need it again? -- To view, visit http://gerrit.cloudera.org:8080/7690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5481cc0477f4d23d89b68ef510a6c9a2aa187537 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
