Alexey Serbin has posted comments on this change. Change subject: KUDU-2130: java client: handle termination during negotiation edge case ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7960/1/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: Line 296 I would update it to be: assert queuedMessages == null || queuedMessages.isEmpty(); PS1, Line 270: queuedMessages.isEmpty() > I think NPE could still happen here. It would be necessary to check for st i.e., consider changing to while (state != State.TERMINATED && !queuedMessages.isEmpty()) { ... } -- To view, visit http://gerrit.cloudera.org:8080/7960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e9d4a6535ae82973743e4ac1071de0aac92b08b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
