Adar Dembo has posted comments on this change. Change subject: catalog_manager: improve IsAlterInProgress performance ......................................................................
Patch Set 2: (3 comments) > What's your thoughts on test coverage, are you assuming we have > enough coverage of this already? My take was that since this patch doesn't change any externally-visible semantics, existing test coverage should suffice. That's also why I looped alter_table-randomized-test. That said, I do think our stress testing of AlterTable is somewhat lacking. There's some coverage in master-stress-test, but that's about it. If you can suggest an interesting concurrent test or two, I would consider adding it. > Only thing I might like to see is > more debug-enabled 'sanity checks' that the versions map is > consistent in certain scenarios. E.g. maybe add a check that if a > tablet is dropped and the # of tablets is 0, the versions map is > empty. I added the one you suggested. If you have others, let me know. http://gerrit.cloudera.org:8080/#/c/7950/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 4381: if (it->first == TabletInfo::NOT_YET_REPORTED) { > Can't this check be skipped? Done Line 4389: return it->first < version; > I recommend casting version to an int64_t explicitly. It's ambiguous which Done http://gerrit.cloudera.org:8080/#/c/7950/2/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: Line 161: // Simple accessor for reported_schema_version_. > Should this doc line be moved to be aove reported_schema_version()? I was doing the stylistic thing where if an enum/typdef only applies to one method, I like to lump it in with the comment block for that method. But since it's proven to be confusing here, I'll separate them. -- To view, visit http://gerrit.cloudera.org:8080/7950 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8c1f48c0febad038833edd555ee88f1db83249d Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
