Dan Burkert has posted comments on this change. Change subject: KUDU-2130 (part 2): more fixes for ITClientStress ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7964/1/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: Line 216: try { > Would it make sense to add the short-circuiting I'm not sure, but it couldn't hurt, so I'll add it. Line 354: return; > I'm curious -- did it happen in the wild that the message arrived in here b Yep, found the following in an ITClientStress log: 21:47:36.158 [ERROR - New I/O worker #1119] (Connection.java:423) [peer master-127.23.143.1:64034] unexpected exception from downstream on [id: 0xb7be1b31, /127.0.0.1:55649 :> /127.23.143.1:64034] java.lang.IllegalStateException at com.google.common.base.Preconditions.checkState(Preconditions.java:429) at org.apache.kudu.client.Connection.messageReceived(Connection.java:350) at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70) at org.apache.kudu.client.Connection.handleUpstream(Connection.java:236) PS1, Line 427: assert !explicitlyDisconnected; > I'm not sure it's good to have this assertion here -- this case covers not Done -- To view, visit http://gerrit.cloudera.org:8080/7964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3f518513931c660fd93b4272d1b1fceb268f191 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
