Hao Hao has posted comments on this change. Change subject: KUDU-2134: Defer block transaction commit to the end of a tablet copy ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7966/1//COMMIT_MSG Commit Message: PS1, Line 10: to expi > to expire Done http://gerrit.cloudera.org:8080/#/c/7966/1/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: Line 125: // WALs downloaded so far. Does nothing if called after Finish(). > Why not do this as part of Finish? You could make the BlockTransaction part Done http://gerrit.cloudera.org:8080/#/c/7966/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: Line 46: #include "kudu/fs/data_dirs.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/7966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4feabc08c2199aad8d08be56f09ac06924345f2b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
