Dan Burkert has posted comments on this change. Change subject: KUDU-1807: improve IsCreateInProgress performance ......................................................................
Patch Set 3: (3 comments) overall I agree with Todd, I'm finding it very difficult to understand the intricacies of the locking in this patch (as opposed to the simpler patch earlier). http://gerrit.cloudera.org:8080/#/c/7957/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 4605: DCHECK_EQ(calculated, tablet_state_counts_); Would it be good to verify the overall count against the total tablet count, or is that implicitly done already? http://gerrit.cloudera.org:8080/#/c/7957/3/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: Line 800: ScopedTabletInfoCommitter* committer_in, Please add docs about what committer_in and comitter_out do. http://gerrit.cloudera.org:8080/#/c/7957/3/src/kudu/util/cow_object.h File src/kudu/util/cow_object.h: Line 77: if (commit_cb) { how does this work? What is this testing? -- To view, visit http://gerrit.cloudera.org:8080/7957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca379bb1249e54c0b7fbb0df408ed829ab9fbd2 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
