Alexey Serbin has uploaded a new patch set (#2). Change subject: [iwyu_tool.py] fix on the IWYU tool invocation ......................................................................
[iwyu_tool.py] fix on the IWYU tool invocation Fixed the way how include-what-you-use binary is invoked by the iwyu_tool.py wrapper script. Prior to this fix, subprocess.Popen() had the 'shell' argument set to 'True', so any issue with starting the binary was silenced because there would be no OSError exception raised. Overall, if using 'shell=True' for subprocess.Popen(), it wouldn't be feasible to detect that sort of errors via examining the exit code of the started process because include-what-you-use always returns exit code 1 regardless of its findings. I also updated the iwyu.sh script to be more robust in handling possible errors, if any. Prior to this fix, the 'iwyu' CMake target returned success if include-what-you-use binary was not in place. This patch fixes that problem and introduces more robust handling of other possible issues while working with the include-what-you-use tool. Change-Id: Ifa4284857583fff6543f65a9c2a71a9e445f39e2 --- M build-support/iwyu/iwyu.sh M build-support/iwyu/iwyu_tool.py 2 files changed, 24 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/7989/2 -- To view, visit http://gerrit.cloudera.org:8080/7989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifa4284857583fff6543f65a9c2a71a9e445f39e2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
