Adar Dembo has posted comments on this change. Change subject: KUDU-2138 delete failed replicas in tablet report ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Looks OK, but would prefer if Mike +2'ed. http://gerrit.cloudera.org:8080/#/c/7992/2/src/kudu/integration-tests/tablet_replacement-itest.cc File src/kudu/integration-tests/tablet_replacement-itest.cc: PS2, Line 184: an a http://gerrit.cloudera.org:8080/#/c/7992/2/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2590: if (report.has_error()) { I'm curious as to why this block was moved down here and not just before the large "if report.has_consensus_state()" block? I can take my answer in the form of a code comment. -- To view, visit http://gerrit.cloudera.org:8080/7992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34abd2cf4d00098a28dd7645053ccdc8341df03c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
