Andrew Wong has posted comments on this change. Change subject: Fix flakiness of ts_tablet_manager_itest TestFailedTabletsAreReplaced ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7993/1//COMMIT_MSG Commit Message: PS1, Line 15: > Nit: drop this Done PS1, Line 22: it > Nit: drop Done http://gerrit.cloudera.org:8080/#/c/7993/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: Line 146: AssertEventually([&]{ > When using this form of AssertEventually you need to manually call NO_PENDI Done Line 150: }, MonoDelta::FromSeconds(60)); > Is it important to override the default timeout value of 30s? I ran into 3/1000 failures when it was 30s (couldn't get to RUNNING because it was still bootstrapping or copying, not the flake failure). Line 153: wait_until_running(); > Nit: add a blank line just before this. Done -- To view, visit http://gerrit.cloudera.org:8080/7993 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93b41c8196397ea5af42ed9e2aa47e967f7a520e Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
