Alexey Serbin has posted comments on this change. Change subject: [iwyu] kudu-specific mappings for std::tr1 entities ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7998/2/.gitignore File .gitignore: Line 33: README.html > What's this about? Do you convert README.md to README.html using a tool? Yep. Do you think it's not worth adding this into the .gitignore? http://gerrit.cloudera.org:8080/#/c/7998/2/build-support/iwyu/iwyu-filter.awk File build-support/iwyu/iwyu-filter.awk: Line 47: # IWYU="`pwd`/../../thirdparty/clang-toolchain/bin/include-what-you-use; \ > Do you want to add --max_line_length here too? Yep, that would be good, thanks. -- To view, visit http://gerrit.cloudera.org:8080/7998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia448dedcbb09ee23b30a922c7143df9036490d84 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
