Mike Percy has posted comments on this change. Change subject: [tests] fix flakes in delete_table-itest ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7972/3/src/kudu/integration-tests/delete_table-itest.cc File src/kudu/integration-tests/delete_table-itest.cc: PS3, Line 1216: : : Instead of adding the extra functions, could we do this in less by just wrapping the logic of finding the leader and changing the config in an ASSERT_EVENTUALLY()? i.e.: // Loop in case the leader changes between adding and removing a replica. for (int i : {0, 1}) { ASSERT_EVENTUALLY([&] { // Find leader. TServerDetails* leader = nullptr; ASSERT_OK(FindTabletLeader(ts_map_, tablet_id, kTimeout, &leader)); ASSERT_OK(WaitForOpFromCurrentTerm(leader, tablet_id, COMMITTED_OPID, kTimeout)); // Do the config changes and wait for the master to delete the old node. if (i == 0) { ASSERT_OK(AddServer(leader, tablet_id, to_add, RaftPeerPB::VOTER, boost::none, kTimeout)); } else { ASSERT_OK(RemoveServer(leader, tablet_id, to_remove, boost::none, kTimeout)); } }); } -- To view, visit http://gerrit.cloudera.org:8080/7972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7dda40ae1054becaf25963a6d301ecaed5a926f9 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
