Andrew Wong has posted comments on this change. Change subject: KUDU-2123. Auto-vivify cmeta on tombstoned replicas if doesn't exist at startup ......................................................................
Patch Set 9: Code-Review+1 (2 comments) lgtm; Alexey may want to take another look considering cmeta_manager-test has changed a little. http://gerrit.cloudera.org:8080/#/c/7988/8/src/kudu/consensus/consensus_meta_manager.cc File src/kudu/consensus/consensus_meta_manager.cc: PS8, Line 109: RETURN_NOT_OK_PREPEND(ConsensusMetadata::DeleteOnDiskData(fs_manager_, tablet_id), : Substitute("Unable to delete consensus metadata for tablet $0", tablet_id)); > That's true. I've just updated the header file comment to note that NotFoun Ah right, gotcha http://gerrit.cloudera.org:8080/#/c/7988/7/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS7, Line 1088: guarantees that the replica has never voted in a leader election. > I think I agree with what you said. But when it comes to consensus, you hav Hah, you're right. I guess "normal" for the purposes of my comment would be where no one is intentionally deleting and recreating cmeta files for tablets that have voted already. That sort of thing generally doesn't happen, and if it never does, the assumption should always be true: the nonexistence of a cmeta file implies that the replica has not voted. -- To view, visit http://gerrit.cloudera.org:8080/7988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff6255b1fcbb12417b82853bcde9b239291492b Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
