Adar Dembo has posted comments on this change. Change subject: Avoid a few allocations while reading PBC files ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8009/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 573: return DoReadV(fd_, filename_, offset, &(*results)[0], results->size()); BTW, isn't results->data() a cleaner way to get at the vector's backing buffer? -- To view, visit http://gerrit.cloudera.org:8080/8009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I228f26416b750c5a30ec6cc0763257c7d8b8d56f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
