Adar Dembo has posted comments on this change.

Change subject: catalog_manager: various boring cleanup
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7990/3/src/kudu/master/catalog_manager.cc
File src/kudu/master/catalog_manager.cc:

Line 2489:     const string delete_msg = report_opid_index == 
consensus::kInvalidOpIdIndex ?
> Is this a bug fix?  Seems the behavior is slightly different.
That's 
https://github.com/apache/kudu/commit/cd6eee7a375e053f1f9bed338e603bf9ca91e709; 
I merely rebase on top of it. If you look at the Base-->PS3 diff, you won't see 
any changes here.

I don't actually know the answer to your question; best to ask Andrew or Mike.


-- 
To view, visit http://gerrit.cloudera.org:8080/7990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028611361ae7d5ce2818707c203c045dbce294c6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to